- This topic has 16 replies, 10 voices, and was last updated 1 year, 8 months ago by
.
-
Can you change the poinerlock activation listener
from this
scope.domElement.addEventListener('click', pointerLockRequest)
to this?
scope.domElement.addEventListener('pointerdown', pointerLockRequest)
It would be more handy…Every time a user opens or reloads the puzzles editor (after saving) all
exec scriptpuzzles gain one more empty string
Puzzles and JS. Fast and expensive.
If you don’t see the meaning in something it primarily means that you just don’t see it but not the absence of meaning at all.
Verge3D team, why do you create
var VARSwith everyexec script? Can’t you do it only twice likevar PROC?
And why do you use such a complicated construction for
exec script?
This code will do exactly the same and there’s no need in
var VARSandvar PROC…
Puzzles and JS. Fast and expensive.
If you don’t see the meaning in something it primarily means that you just don’t see it but not the absence of meaning at all.
Verge3D team, why do you create var VARS with every exec script? Can’t you do it only twice like var PROC?
Hi, that’s a good question! VARS is a bit more complex than PROC – if execScript is used inside a procedure puzzle then it needs access to parameter arguments as well as to global variables.
For example in the following puzzle setup the first execScript puzzle should reference global “test” while the second one the local parameter “test”:
– this is achieved by declaring VARS two times so each of those declarations has correct variables in its closure.On the other hand VARS doesn’t have to be declared each time execScript is used, it only needs to appear once for the global scope and for every procedure that uses execScript inside.
Initially, there was a measure to detect if we need to declare VARS at each particular place in code but it was commented out due to some issues. We might need to look further into that, because clearly the current approach can be optimized.
This code will do exactly the same and there’s no need in var VARS and var PROC…
In general, variables and procedures in the puzzles editor can have names that are not valid JS identifiers, like the default “do something” procedure name. They are renamed in the generated code to make sure that it works. Also, some of them can be renamed just to avoid collisions, e.g. “do_something”, “do_something2”, etc…
So, unless you check the visual_logic.js file you can’t always be sure that the name of your variable/procedure stays the same when it comes to executing the contents of execScript. VARS and PROC are used to avoid something like that by providing mapping between the original names and the resulting identifiers.
Co-founder and lead developer at Soft8Soft.
- You must be logged in to reply to this topic.